Re: [PATCH 2/3]virt-viewer: Register a new signal 'session-cancelled'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jan 15, 2012 at 7:29 AM, Guannan Ren <gren@xxxxxxxxxx> wrote:
> +               } else {
> +                       g_signal_emit_by_name(session, "session-auth-refused",
> +                                              _("Unable to collect credentials"));

it looks like it was wrong to emit "session-auth-refused" in the first
place, if the dialog is cancelled.

So we could keep the current 2 return values meaning: -1 cancel, 0 ok.

-- 
Marc-André Lureau


[Index of Archives]     [Linux Virtualization]     [KVM Development]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux