I'm a bit confused by derives-from VS upgrades here, but anyway my understanding is that we don't have a clear consensus on what sound driver to use for what windows version (AC97 VS ICH6), so I'll let Marc-André/Daniel weight on this one first. What the patch is doing is using ICH6 for Vista, Win7 and Win2008, and AC97 for anything older. Christophe On Thu, Dec 22, 2011 at 12:08:01AM +0200, Zeeshan Ali (Khattak) wrote: > From: "Zeeshan Ali (Khattak)" <zeeshanak@xxxxxxxxx> > > --- > data/oses/fedora.xml | 6 ++++++ > data/oses/windows.xml | 21 ++++++++++++++++++--- > 2 files changed, 24 insertions(+), 3 deletions(-) > > diff --git a/data/oses/fedora.xml b/data/oses/fedora.xml > index efc1f5f..151c5ff 100644 > --- a/data/oses/fedora.xml > +++ b/data/oses/fedora.xml > @@ -9,6 +9,7 @@ > > <devices> > <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1b36/0100"/> <!-- QXL --> > + <device id="http://pciids.sourceforge.net/v2.2/pci.ids/8086/2415"/> <!-- AC97 --> > </devices> > </os> > > @@ -136,6 +137,11 @@ > <kernel>isolinux/vmlinuz</kernel> > <initrd>isolinux/initrd.img</initrd> > </media> > + > + <devices> > + <!-- FIXME: No idea in which release suppport was added, just making a safe assumption here --> > + <device id="http://pciids.sourceforge.net/v2.2/pci.ids/8086/2668"/> <!-- ICH6 --> > + </devices> > </os> > > <os id="http://fedoraproject.org/fedora/14";> > diff --git a/data/oses/windows.xml b/data/oses/windows.xml > index 7a7bce3..78a7942 100644 > --- a/data/oses/windows.xml > +++ b/data/oses/windows.xml > @@ -10,6 +10,21 @@ > <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1b36/0100"/> <!-- QXL --> > <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1234/1111"/> <!-- VGA --> > <device id="http://www.linux-usb.org/usb.ids/80ee/0021"/> <!-- USB tablet --> > + <device id="http://pciids.sourceforge.net/v2.2/pci.ids/8086/2415"/> <!-- AC97 --> > + </devices> > + </os> > + > + <os id="http://microsoft.com/modern-windows";> > + <short-id>modern-windows</short-id> > + <name>Microsoft Windows (7/2008/Vista/etc)</name> > + <vendor>Microsoft</vendor> > + <family>Windows</family> > + > + <devices> > + <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1b36/0100"/> <!-- QXL --> > + <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1234/1111"/> <!-- VGA --> > + <device id="http://www.linux-usb.org/usb.ids/80ee/0021"/> <!-- USB tablet --> > + <device id="http://pciids.sourceforge.net/v2.2/pci.ids/8086/2668"/> <!-- ICH6 --> > </devices> > </os> > > @@ -202,7 +217,7 @@ > <version>6.0</version> > <vendor>Microsoft</vendor> > <family>Windows</family> > - <derives-from id="http://microsoft.com/windows"/> > + <derives-from id="http://microsoft.com/modern-windows"/> > <upgrades id="http://microsoft.com/win2k3"/> > > <media arch="x86_64"> > @@ -249,7 +264,7 @@ > <version>6.0</version> > <vendor>Microsoft</vendor> > <family>Windows</family> > - <derives-from id="http://microsoft.com/windows"/> > + <derives-from id="http://microsoft.com/modern-windows"/> > <upgrades id="http://microsoft.com/winxp"/> > > <resources arch="all"> > @@ -273,7 +288,7 @@ > <version>6.1</version> > <vendor>Microsoft</vendor> > <family>Windows</family> > - <derives-from id="http://microsoft.com/windows"/> > + <derives-from id="http://microsoft.com/modern-windows"/> > <upgrades id="http://microsoft.com/vista"/> > > <media arch="i386"> > -- > 1.7.7.4 > > _______________________________________________ > virt-tools-list mailing list > virt-tools-list@xxxxxxxxxx > https://www.redhat.com/mailman/listinfo/virt-tools-list
Attachment:
pgpq3V625H0Go.pgp
Description: PGP signature
