Looking at Henning Heinholdâs patch [1] he changed the includes to the C++ headers instead of the C headers. At least Wikipedia says [2], that the C headers are deprecated.
C++ provides this functionality in the header cstdarg; the C header, though permitted, is deprecated in C++.
Is it desirable to change the includes in all files? If yes, is there a tool which would accomplish this, since after the substitution a reordering is needed?
[1] http://cgit.openembedded.org/cgit.cgi/openembedded/tree/recipes/vdr/files/cplusplus.patch?id=97e1b707d6504343f02e683f49eb2cb6db2cc091
[2] https://secure.wikimedia.org/wikipedia/en/wiki/Stdarg.h
Signed-off-by: Paul Menzel <paulepanter@xxxxxxxxxxxxxxxxxxxxx>
---
tools.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/tools.c b/tools.c
index 3ce12ec..9a400a8 100644
--- a/tools.c
+++ b/tools.c
@@ -8,9 +8,12 @@
*/
#include "tools.h"
-#include <ctype.h>
+#include <cctype>
+#include <cerrno>
+#include <cstdarg>
+#include <cstdlib>
+#include <ctime>
#include <dirent.h>
-#include <errno.h>
extern "C" {
#ifdef boolean
#define HAVE_BOOLEAN
@@ -18,11 +21,8 @@ extern "C" {
#include <jpeglib.h>
#undef boolean
}
-#include <stdarg.h>
-#include <stdlib.h>
#include <sys/time.h>
#include <sys/vfs.h>
-#include <time.h>
#include <unistd.h>
#include <utime.h>
#include "i18n.h"
--
1.7.2.3
Attachment:
signature.asc
Description: This is a digitally signed message part
_______________________________________________ vdr mailing list vdr@xxxxxxxxxxx http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
