Re: [PATCH v3] Gather necessary options for build in Make.global and include it.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Samstag, den 06.02.2010, 13:17 +0100 schrieb Klaus Schmidinger:
> On 29.01.2010 15:19, Paul Menzel wrote:

[…]

> > --- a/PLUGINS/src/dvbsddevice/Makefile
> > +++ b/PLUGINS/src/dvbsddevice/Makefile
> > @@ -18,7 +18,11 @@ VERSION = $(shell grep 'static const char \*VERSION *=' $(PLUGIN).c | awk '{ pri
> >  ### The C++ compiler and options:
> >  
> >  CXX      ?= g++
> > -CXXFLAGS ?= -fPIC -g -O2 -Wall -Woverloaded-virtual -Wno-parentheses
> > +CXXFLAGS ?= -g -O2 -Wall -Woverloaded-virtual -Wno-parentheses
> > +
> > +### Make sure that necessary options are included:
> > +
> > +include $(VDRDIR)/Make.global
> > ...
> 
> This fails when doing
> 
>   make clean-plugins
> 
> make[1]: Entering directory `/home/kls/vdr/VDR/PLUGINS/src/dvbsddevice'
> Makefile:25: /Make.global: No such file or directory
> make[1]: *** No rule to make target `/Make.global'.  Stop.
> make[1]: Leaving directory `/home/kls/vdr/VDR/PLUGINS/src/dvbsddevice'
> 
> Apparently $(VDRDIR) is not yet defined at that point.

Fixed.

> > ... 
> > diff --git a/newplugin b/newplugin
> > index 52ef72e..6c9be35 100755
> > --- a/newplugin
> > +++ b/newplugin
> > @@ -77,7 +77,11 @@ VERSION = \$(shell grep 'static const char \\*VERSION *=' \$(PLUGIN).c | awk '{
> >  ### The C++ compiler and options:
> >  
> >  CXX      ?= g++
> > -CXXFLAGS ?= -fPIC -g -O2 -Wall -Woverloaded-virtual -Wno-parentheses
> > +CXXFLAGS ?= -g -O2 -Wall -Woverloaded-virtual -Wno-parentheses
> > +
> > +### Make sure that necessary options are included:
> > +
> > +include $(VDRDIR)/Make.global
> 
> I assume this last line should read
> 
> +include \$(VDRDIR)/Make.global

Fixed.

> Please provide a revised (and tested ;-) patch.

I sent the revised and tested (`make`, `make plugins`, `make
clean-plugins`) patch to the list.

 [PATCH v4] Gather necessary options for build in Make.global and include it.


Sorry for the inconvenience. Thanks,

Paul


[1] http://www.linuxtv.org/pipermail/vdr/2010-February/022333.html

Attachment: signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil

_______________________________________________
vdr mailing list
vdr@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr

[Index of Archives]     [Linux Media]     [Asterisk]     [DCCP]     [Netdev]     [Xorg]     [Util Linux NG]     [Xfree86]     [Big List of Linux Books]     [Fedora Users]     [Fedora Women]     [ALSA Devel]     [Linux USB]

  Powered by Linux