Re: VDR 1.7 and no subtitles with old PES recordings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 6 Oct 2009, jjtt@xxxxxxxx wrote:

I'm contemplating updating my trusty 1.6.0 to the latest
development version, but I can't seem to get DVB subtitles
from old recordings to work.

Subtitles are shown corretly both when viewing live tv and
when viewing new recordings, but when viewing old PES
recordings VDR just says that no subtitles are available.

I'm using vanilla VDR and the xineliboutput plugin.

Zimiq did all the hard work to pinpoint the faulty method: http://www.linuxtv.fi/viewtopic.php?p=24394#24394

At least this patch did help on my few old recordings:

--- dvbsubtitle.c.orig   2009-11-17 18:29:16.000000000 +0200
+++ dvbsubtitle.c   2009-11-17 18:30:44.000000000 +0200
@@ -699,7 +699,7 @@
         }

      if (Length > PayloadOffset + SubstreamHeaderLength) {
-        int64_t pts = PesGetPts(Data);
+        int64_t pts = PesHasPts(Data) ? PesGetPts(Data) : 0;
         if (pts)
            dbgconverter("Converter PTS: %lld\n", pts);
         const uchar *data = Data + PayloadOffset + SubstreamHeaderLength; // skip substream header


BR,
--
rofa

_______________________________________________
vdr mailing list
vdr@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr

[Index of Archives]     [Linux Media]     [Asterisk]     [DCCP]     [Netdev]     [Xorg]     [Util Linux NG]     [Xfree86]     [Big List of Linux Books]     [Fedora Users]     [Fedora Women]     [ALSA Devel]     [Linux USB]

  Powered by Linux