Bug in SVDRP-hosts-parser

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Klaus,

i found a bug in the computing of the Netmask for the SVDRP-Hosts-file.
The byte order in your case was not correctly computed.
Here is a patch.

============= snip ==========
--- config.c.orig       2006-07-01 16:53:25.000000000 +0200
+++ config.c    2006-07-01 16:53:33.000000000 +0200
@@ -106,8 +106,10 @@
      *(char *)p = 0; // yes, we know it's 'const' - will be restored!
      if (m == 0)
         mask = 0;
-     else
-        mask >>= (32 - m);
+     else {
+        mask <<= (32 - m);
+       mask = htonl(mask);
+       }
      }
   int result = inet_aton(s, &addr);
   if (p)
============= snip ==========

Greets
Patrick

-- 
     There are only 10 kind of people who understand binary digits:
     Those who do - Those who don't...


[Index of Archives]     [Linux Media]     [Asterisk]     [DCCP]     [Netdev]     [Xorg]     [Util Linux NG]     [Xfree86]     [Big List of Linux Books]     [Fedora Users]     [Fedora Women]     [ALSA Devel]     [Linux USB]

  Powered by Linux