Prakash Punnoor wrote: > Am Samstag April 29 2006 12:38 schrieb Prakash Punnoor: >> attached patch fixes that vdr (the executable and the static lib libpsi) >> get compiled with fPIC. Only shared libs need PIC, thus add this flag only >> when building plug-ins. Furthermore I added -g and -Wall to CFLAGS, as >> well, because of reasons of symmetry. > > Updated patch: I forgot to add -g -Wall to Make.conf.template... > > diff -urd vdr-1.3.49/libsi/Makefile vdr-1.3.49.n/libsi/Makefile > --- vdr-1.3.49/libsi/Makefile 2005-05-29 13:47:12.000000000 +0200 > +++ vdr-1.3.49.n/libsi/Makefile 2006-04-29 12:13:59.000000000 +0200 > @@ -6,7 +6,7 @@ > ### The C++ compiler and options: > > CXX ?= g++ > -CXXFLAGS ?= -fPIC -O2 -g -Wall -Woverloaded-virtual > +CXXFLAGS ?= -O2 -g -Wall -Woverloaded-virtual > AR = ar > ARFLAGS = ru > RANLIB = ranlib > diff -urd vdr-1.3.49/Make.config.template vdr-1.3.49.n/Make.config.template > --- vdr-1.3.49/Make.config.template 2006-04-15 14:28:03.000000000 +0200 > +++ vdr-1.3.49.n/Make.config.template 2006-04-29 12:41:21.000000000 +0200 > @@ -11,10 +11,10 @@ > ### The C compiler and options: > > CC = gcc > -CFLAGS = -O2 > +CFLAGS = -g -O2 -Wall > > CXX = g++ > -CXXFLAGS = -fPIC -g -O2 -Wall -Woverloaded-virtual > +CXXFLAGS = -g -O2 -Wall -Woverloaded-virtual > > ### The directory environment: > > diff -urd vdr-1.3.49/Makefile vdr-1.3.49.n/Makefile > --- vdr-1.3.49/Makefile 2006-04-24 19:18:06.000000000 +0200 > +++ vdr-1.3.49.n/Makefile 2006-04-29 12:33:23.000000000 +0200 > @@ -9,10 +9,10 @@ > .DELETE_ON_ERROR: > > CC ?= gcc > -CFLAGS ?= -O2 > +CFLAGS ?= -g -O2 -Wall > > CXX ?= g++ > -CXXFLAGS ?= -fPIC -g -O2 -Wall -Woverloaded-virtual > +CXXFLAGS ?= -g -O2 -Wall -Woverloaded-virtual > > LSIDIR = ./libsi > MANDIR = /usr/local/man Ok, I'll do this for maintenance patch 1.4.0-2. > @@ -175,6 +175,8 @@ > # Plugins: > > plugins: include-dir > + CFLAGS="-fPIC $(CFLAGS)" > + CXXFLAGS="-fPIC $(CXXFLAGS)" > @failed="";\ > noapiv="";\ > for i in `ls $(PLUGINDIR)/src | grep -v '[^a-z0-9]'`; do\ Why would this be necessary? The plugins' Makefiles already contain CXXFLAGS ?= -fPIC -g -O2 -Wall -Woverloaded-virtual Klaus
