Rolf Ahrenberg wrote: > On Fri, 20 Jan 2006, Klaus Schmidinger wrote: > >> Rolf Ahrenberg wrote: >> >>> >>> Hi, >>> >>> here's a little patch to prevent crashing on Digita network, that >>> uses 'NULL' in some event titles. >> >> >> After some thought I believe it's probably better to do the following, >> because an event should always have at least a title. > > > The functionality of your patch is exactly the same as in my > vdr-1.3.3?-epg-bugfix.diff patches. However, I'm pretty sure I merged it > before I started testing the 1.3.39, so does it really fix the problem? > Should the fixup for title be done in cEvent::SetTitle() by changing > 'NULL' titles to " "? Well, originally I wanted the events to be left exactly as they came off the air if the bugfix level is 0. However, events that don't even have a title make no sense, so they shall always have one. cEvent::SetTitle() is probably not a good place for this, because it isn't guaranteed to be called at all. The only real good place to do this would probably be the cEvent constructor, but that would mean setting the title to something that in 99.9% of all cases will be overwritten. Since cEvent::FixEpgBugs() is called for all events that are broadcast, it now makes sure every event actually has a non-NULL title. The only loophole left is SVDRP's PUTE command, but the man page states that "every event should at least have a T entry". Maybe I should make that a "must". Klaus
