Error in cPalette::Take (osd.c) ?

[eike at edener.de (Eike Edener)]

Hi,

I'm currently writing my own plugin (VDR 1.3.37) using
  - cBitmap::LoadXpm() to load a bitmap and
  - cOsd::DrawBitmap() to draw it with changed background color
    (NOT changed foreground color).

Because I neither want to change the foreground color nor
know the foreground color value (tColor), I think it is good to
change this part in cPalette::Take() (osd.c line 77-82):

       if (ColorFg || ColorBg) {
          switch (i) {
            case 0: Color = ColorBg; break;
            case 1: Color = ColorFg; break;
            }
          }

to

if (i == 0 && ColorBg) Color = ColorBg;
if (i == 1 && ColorFg) Color = ColorFg;

Eike