This series looks good to me!
Reviewed-by: zhenwei pi <pizhenwei@xxxxxxxxxxxxx>
On 3/4/25 09:38, Joe Jin wrote:
On 3/3/25 02:16, Karel Zak wrote:
On Fri, Feb 28, 2025 at 08:13:30AM GMT, Joe Jin wrote:
This patchset add below new options for irqtop:
'-b|--batch' : Batch mode
'-n|--iter' : Specifies the maximum number of iterations
'-J|--json' : Json ouput format
Add below for lsirq:
'-i|--input' : Read data from file
v2:
- Removed macro irqtop_batch_mode.
- Replaced macro irqtop_printf() to inline function
- Changed option '--number' to '--iter'
- Replace strdup() to xstrdup()
- Added json output format for irqtop.
- Remove irqtop input file support.
Joe Jin (4):
irqtop: add batch mode support
irqtop: add max iteration support
irqtop: support json output format
lsirq: add support for reading data from given file
bash-completion/irqtop | 12 +++-
bash-completion/lsirq | 4 ++
sys-utils/irq-common.c | 19 +++---
sys-utils/irq-common.h | 3 +-
sys-utils/irqtop.1.adoc | 9 +++
sys-utils/irqtop.c | 124 +++++++++++++++++++++++++++++++---------
sys-utils/lsirq.1.adoc | 3 +
sys-utils/lsirq.c | 24 ++++++--
8 files changed, 155 insertions(+), 43 deletions(-)
Thanks for the update. I have created a PR
(https://github.com/util-linux/util-linux/pull/3435) to test it with
CI tests.
Thanks so much!
Karel
