Hi,
Apr 16, 2024 02:30:10 Masatake YAMATO <yamato@xxxxxxxxxx>:
> From: John Paul Adrian Glaubitz <glaubitz@xxxxxxxxxxxxxxxxxxx>
> Subject: lsfd/error-eperm test fails on git master
> Date: Mon, 15 Apr 2024 12:24:08 +0200
>
>> Hello,
>>
>> lsfd/error-eperm fails for me on git master. I have reproduced the issue
>> on 32-bit PowerPC, 64-bit SPARC, 64-bit s390x and x86_64.
>>
>> Is there a tentative fix for this failure?
>
> Thank you for reporting.
> This may be a bug in a build script.
>
>> Thanks,
>> Adrian
>>
>> (sid_powerpc-dchroot)glaubitz@perotto:~/util-linux-git/tests$ ./run.sh lsfd/error-eperm
>>
>> -------------------- util-linux regression tests --------------------
>>
>> For development purpose only.
>> Don't execute on production system!
>>
>> kernel: 6.6.15-powerpc64
>>
>> options: --srcdir=/home/glaubitz/util-linux-git/tests/.. \
>> --builddir=/home/glaubitz/util-linux-git/tests/..
>>
>> lsfd: fd opening a file cannot be stat(2)'ed ... FAILED (lsfd/error-eperm)
>>
>> ---------------------------------------------------------------------
>> 1 tests of 1 FAILED
>>
>> lsfd/error-eperm
>> ---------------------------------------------------------------------
>> (sid_powerpc-dchroot)glaubitz@perotto:~/util-linux-git/tests$
>>
>> diff-{{{
>> --- /home/glaubitz/util-linux-git/tests/expected/lsfd/error-eperm 2024-04-09 09:22:29.505017516 +0000
>> +++ /home/glaubitz/util-linux-git/tests/output/lsfd/error-eperm 2024-04-15 08:37:38.326220593 +0000
>> @@ -1,2 +1,2 @@
>> -mem ERROR stat:EPERM
>> +mem ERROR stat:unknown(1)
>
> EPERM is defined as 1 in asm-generic/errno-base.h.
> So `unknown(1)' should be decoded as EPERM.
>
> lsns uses errnos.h generated at build-time for decoding the error numbers.
The build log should be the same as reported before:
https://buildd.debian.org/status/fetch.php?pkg=util-linux&arch=powerpc&ver=2.40-5&stamp=1712589234&raw=0
Which indeed contains:
GEN syscalls.h
./tools/all_syscalls: line 13: gawk: command not found
So it should be the same issue as
https://github.com/util-linux/util-linux/pull/2949
(which needs to be expanded to all_errnos and meson)
I can send a patch but wanted to wait for the original submitter.
> Can I see errnos.h at the top of the build directory ?
> I guess the file is at ~/util-linux-git/errnos.h.
>
>
> On my environment, the head of the file is:
>
> UL_ERRNO("E2BIG", E2BIG)
> UL_ERRNO("EACCES", EACCES)
> UL_ERRNO("EADDRINUSE", EADDRINUSE)
> UL_ERRNO("EADDRNOTAVAIL", EADDRNOTAVAIL)
> UL_ERRNO("EADV", EADV)
> UL_ERRNO("EAFNOSUPPORT", EAFNOSUPPORT)
> ...
>
> Masatake YAMATO
>
>> ASSOC,TYPE,SOURCE: 0
>> }}}-diff
>>
>> libsmartcols: fromfile: [15] wrap-tree ... OK
>> lsfd: fd opening a file cannot be stat(2)'ed ... FAILED (lsfd/error-eperm)
