Hi, thanks for the tests! On 2023-12-09 14:20:19-0800, Edward Chron wrote: > Submission to Project: util-linux > Open Incident: #2637 at github.com/util-linux/util-linux/issues/2637 > Component: util-linux/sys-utils > File: dmesg.c > Code level patch applied against: https://github.com/t-8ch/util-linux/ > and we used his local-dmesg-tests from t8ch/dmesg/tests > as we needed the numerous improvements and fixes that Thomas has > made to the code. > [..] > Tests include syslog-printk-caller versions of all existing tests: > > -------------------- util-linux regression tests -------------------- > > For development purpose only. > Don't execute on production system! > > kernel: 6.6.4-200.fc39.x86_64 > > options: --srcdir=/usr/src/util-linux/pending/util-linux/tests/.. \ > --builddir=/usr/src/util-linux/pending/util-linux/tests/.. > > dmesg: colors ... OK > dmesg: colors-syslog-prtk-caller ... OK > dmesg: levels ... OK > dmesg: levels-syslog-prtk-caller ... OK > dmesg: decode ... OK > dmesg: decode-syslog-prtk-caller ... OK > dmesg: delta ... OK > dmesg: delta-syslog-prtk-caller ... OK > dmesg: facilities ... OK > dmesg: facilities-syslog-prtk-caller ... OK > dmesg: indentation ... OK > dmesg: indent-syslog-printk-caller ... OK > dmesg: limit ... OK > dmesg: limit-syslog-prtk-caller ... OK Do we need so many new testcases? Wouldn't two tests be enough to be sure that the new logic works? One for the syslog parsing logic and one for the /dev/kmsg one? Thomas
