Re: [PATCH 1/3] schedutils: clarify confusing mask example in taskset man page

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Sat Jan 7, 2023 at 8:47 PM CET,  wrote:
> From: Alison Chaiken <alison@xxxxxxxxxxxxx>
>
> Omit "0x" from a mask example which is clearly hexadecimal rather than omitting
> it from "32", which could be a decimal representation.
> ---
>  schedutils/taskset.1.adoc | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/schedutils/taskset.1.adoc b/schedutils/taskset.1.adoc
> index c10cc62a2..efbab08dc 100644
> --- a/schedutils/taskset.1.adoc
> +++ b/schedutils/taskset.1.adoc
> @@ -52,10 +52,10 @@ is processor #0,
>  *0x00000003*::
>  is processors #0 and #1,
>  
> -*0xFFFFFFFF*::
> +*FFFFFFFF*::
>  is processors #0 through #31,
>  
> -*32*::
> +*0x32*::
>  is processors #1, #4, and #5,
>  
>  *--cpu-list 0-2,6*::
> -- 
> 2.32.0

I'd keep the `0x` prefix simply for consistency reasons.
It's easy for the eye to recognize the character sequence as a number
and looks cleaner in general.

The second change, however, I think is right for the very same reason.

--
Best Regards,
Tom Schwindl




[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux