Re: [PATCH] blkpr: add block persistent reservations command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 06, 2022 at 10:55:24AM +0200, Karel Zak wrote:
> At first glance it seems like something I can merge.

Merged. I did some minor changes to the code and man-page.

It would be nice to have some short description for the operations and
the types. Something what we can use in --help output.

  register, reserve, release, preempt, preempt-abort, and clear

  write-exclusive, exclusive-access, write-exclusive-reg-only, exclusive-access-reg-only, write-exclusive-all-regs, and exclusive-access-all-regs

I'm not sure if for example "preempt" or "write-exclusive-reg-only" is
obvious enough for end-users.

The next question, what about to rename --operation to --command?  The
man-page describes blkpr as "run persistent reservations command on a
device".

 Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com




[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux