Re: [PATCH 0/2] libblkid: don't use O_NONBLOCK for floppy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 09, 2021 at 03:12:31PM +0100, Vladimir Sementsov-Ogievskiy wrote:
> Good day everyone!
> 
> The commit "floppy: reintroduce O_NDELAY fix" was removed from kernel,
> so we faced the bug described and discussed here:
> https://bugzilla.suse.com/show_bug.cgi?id=1181018
> 
> Discussion in kernel list on reverting the commit:
> https://www.spinics.net/lists/stable/msg493061.html
> 
> In short, I can quote Jiri Kosina's comment:
> 
>    opening floppy device node with O_NONBLOCK is asking for all kinds
>    of trouble
> 
> So opening floppy with O_NONBLOCK in blkid leads to failure of blkid,
> probable failure of mount and unpleasant error messages in dmesg (see
> also patch 02 for details).
> 
> Vladimir Sementsov-Ogievskiy (2):
>   libblkid: introduce blkid_safe_open
>   libblkid: reopen floppy without O_NONBLOCK

Reviewed-by: Michal Suchánek <msuchanek@xxxxxxx>

See nit in patch 2.

Thanks

Michal
> 
>  libblkid/src/blkid.h.in   |  2 ++
>  libblkid/src/evaluate.c   |  2 +-
>  libblkid/src/libblkid.sym |  4 ++++
>  libblkid/src/probe.c      | 44 ++++++++++++++++++++++++++++++++++++++-
>  libblkid/src/verify.c     |  2 +-
>  misc-utils/blkid.c        |  2 +-
>  misc-utils/wipefs.c       |  2 +-
>  7 files changed, 53 insertions(+), 5 deletions(-)
> 
> -- 
> 2.31.1
> 



[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux