On Thu, 9 Dec 2021, Vladimir Sementsov-Ogievskiy wrote: > Good day everyone! > > The commit "floppy: reintroduce O_NDELAY fix" was removed from kernel, > so we faced the bug described and discussed here: > https://bugzilla.suse.com/show_bug.cgi?id=1181018 > > Discussion in kernel list on reverting the commit: > https://www.spinics.net/lists/stable/msg493061.html > > In short, I can quote Jiri Kosina's comment: > > opening floppy device node with O_NONBLOCK is asking for all kinds > of trouble > > So opening floppy with O_NONBLOCK in blkid leads to failure of blkid, > probable failure of mount and unpleasant error messages in dmesg (see > also patch 02 for details). > > Vladimir Sementsov-Ogievskiy (2): > libblkid: introduce blkid_safe_open > libblkid: reopen floppy without O_NONBLOCK Ah, thanks, finally someone found the motivation to look into what it'd take to fix this properly in libblkid. FWIW, Acked-by: Jiri Kosina <jkosina@xxxxxxx> for the changes. Thank you! -- Jiri Kosina SUSE Labs
