On Tue, Dec 29, 2020 at 08:18:14PM +0100, Chris Hofstaedtler wrote: > Hi, > > I just noticed that fsck, when given a single device name, silently > exits when it cannot find an appropriate fsck.%s program. > > Example: > (/dev/sda1 is an EFI System Partition, so type=vfat) > # fsck -V /dev/sda1 > fsck from util-linux 2.36.1 > # echo $? > 0 > > Note that it also does not warn about fsck.vfat not being found or > anything really. > > This appears because fsck.c has a "really_wanted" list of fstypes; > anything not in there gets the mentioned behaviour. > > I find this to be very surprising. What are the reasons for this? I guess to avoid unnecessary warnings on systems with filesystems where fsck is not (or wasn't) implemented like btrfs or xfs. > I could try changing this code path, but I'm not sure if this is > expected in the first place? Maybe we can introduce some another list of filesystems where fsck is optional and recommended, but it's no error when not available -- it means print warning, but do not exit with an error. Karel -- Karel Zak <kzak@xxxxxxxxxx> http://karelzak.blogspot.com
