Hi Karel, On Tue, Dec 08, 2020 at 11:09:10AM +0100, Karel Zak wrote: > On Sat, Dec 05, 2020 at 03:44:10PM +0800, Gao Xiang wrote: > > This patch adds support for detecting EROFS filesystem to libblkid. > > Applied, thanks! Thanks for taking time on this and the image/testcase! > > I have also added simple regression test to tests/ts/blkid/images-fs/erofs.img.xz. > > Note that it seems the current mkfs.erofs cannot set volume_name (aka LABEL) > although the filesystem superblock support it. Yeah, since it has little use-case for now (but leave such field for later use), I will add this feature if needed later :) Thanks for kind reminder! > > > A small nitpick to mkfs.erofs, see https://github.com/hsiangkao/erofs-utils/blob/dev/mkfs/main.c#L27 > > The subdirectory in > > #include <uuid/uuid.h> > > is unnecessary (or wrong), if you use > > PKG_CHECK_MODULES([libuuid], [uuid]) > > than it returns the subdirectory as -I, see > > $ pkg-config --cflags uuid > -I/usr/include/uuid > > so the correct way is > > #include <uuid.h> > > with the proper PKG_CHECK_MODULES(), btw you have it without > subdirectory in configure.ac test. > > The problem is that your code reads the default include file from > /usr/include/uuid/ rather the one specified by your build system. Yay, many thanks for catching this! will fix it soon! Thanks, Gao Xiang > > > Karel > > -- > Karel Zak <kzak@xxxxxxxxxx> > http://karelzak.blogspot.com >
