Hi Jeffrey and Karel, On Wed, Sep 30, 2020 at 07:40:27PM +0200, Karel Zak wrote: > On Wed, Sep 30, 2020 at 09:44:09AM -0500, Jeffrey Bastian wrote: > > On Tue, Sep 29, 2020 at 12:46:27PM +0200, Karel Zak wrote: > > > On Mon, Sep 28, 2020 at 06:46:14PM +0900, Shunsuke Nakamura wrote: > > > > sys-utils/lscpu-arm.c | 6 ++++++ > > > > 1 file changed, 6 insertions(+) > > > > > > Applied, thanks. > > > > > > With the other ARM patch applied ("use SMBIOS tables on ARM for lscpu"), > > the output changes on an FX700 system: > > > > [root@fujitsu-fx700 ~]# ./lscpu | grep -e Vendor -e Model -e Stepping > > Vendor ID: FUJITSU > > Model: 0 > > Model name: 461F0010 > > Stepping: 0x1 > > > > > > The values here come from the SMBIOS Type 4 record: > > > > [root@fujitsu-fx700 ~]# strings /sys/firmware/dmi/entries/4-0/raw > > CPU1 > > FUJITSU > > 461F0010 > > 8K083MH14 > > > > > > This FX700 system has firmware revision 1.4.0 (Jun 17 2020). > > hmm... 461F0010 does not seem user-friendly, "A64FX" seems better. > > Shunsuke, what about to update the firmware strings? ;-) (as Jeffrey > suggested in RH bugzilla) > > The another possibility is to exclude some vendors and do not use > SMBIOS for them (e.g. 0x46 for Fujitsu), but from my point of view > SMBIOS based solution is more elegant and ready for new CPU types than > in-lscpu hard coded tables. According to SMBIOS specification, the description of Processor Version (Type4) is "String number describing the Processor". It shows the version number of the processor, not a model, like as A64FX and Cortex-A72 and so on. So I think we should not use the Processor Version as the modelname... As far as I can see, there's no useful information in SMBIOS to show the modelname, so I suppose we should continue to use id_part structures in lscpu-arm.c. As for Processor Version, how about using lscpu_desc.rversion or adding a new member to lscpu_desc to show the version? Thanks, Masa