On Tue, 12 May 2020 at 09:54, Karel Zak <kzak@xxxxxxxxxx> wrote: > On Wed, May 06, 2020 at 08:19:21PM +0100, Sami Kerola wrote: > > Here are two changes to more(1) that where requested in earlier github > > pull[1] request to get review in maillist, so here we go. > > Applied, thanks. > > > First one of the changes will link more(1) with libmagic so that various > > binary formats can be detected with effect the pager will not mess up > > termial. > > It seems we do not have devel package for libmagic in Fedora. Oh, that's a little disappointing. Archlinux has libmagic in core repository and that lead me thinking it is quite likely part of even most minimal installation, but apparently I was wrong. > > Second change is perhaps a little bit more exciting. It will add page-up, > > page-down, arrow-up, and arrow-down movements to more(1). This pager has > > known now to scroll back and forth since long time ago, but most of the > > people do not seem to know key bindings so lets help users by assigning the > > most obvious buttons the way one might expect them to work. > > This is nice feature, maybe also add arrow keys to move one line > up/down. Funny you said that. The more(1) movements are still quite disappointing when trying to read the code. Sometime before Christmas I will try to address that along with adding posix required more(1) key-bindings. But there is no hope these would be ready before next util-linux release so now we have a little unexpected movements for a bit. I hope that is still an improvement to earlier situation when going backwards seemed to be impossible for most of the users. Thank you for review and merge Karel. -- Sami Kerola http://www.iki.fi/kerolasa/
