Re: [PATCH] libblkid: Add support for zonefs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 01, 2020 at 04:44:29AM +0000, Damien Le Moal wrote:
> On 2020/03/23 19:33, Karel Zak wrote:
> > On Fri, Mar 20, 2020 at 01:55:43PM +0900, Damien Le Moal wrote:
> >>  libblkid/src/Makemodule.am             |  1 +
> >>  libblkid/src/superblocks/superblocks.c |  3 +-
> >>  libblkid/src/superblocks/superblocks.h |  1 +
> >>  libblkid/src/superblocks/zonefs.c      | 87 ++++++++++++++++++++++++++
> >>  4 files changed, 91 insertions(+), 1 deletion(-)
> >>  create mode 100644 libblkid/src/superblocks/zonefs.c
> > 
> > Applied (with a small change), thanks.
> > 
> >> +struct zonefs_super {
> >> +
> >> +	/* Magic number */
> >> +	__le32		s_magic;
> > 
> > We use standard integer types rather than this kernel-ism ;-) Fixed.
> > 
> > It would be nice to have a test image for zonefs, something small what
> > we can add to tests/ts/blkid/images-fs/ ;-)
> 
> Hi Karel,
> 
> Please find attached the zonefs.img.xz file for a small (4 MB uncompressed)
> image of a zonefs file system. I tested it with the blkid run in
> tests/ts/blkid/low-probe and it works. I am not sure if other tests are run
> against FS images as I have not dig into the test suite (I should !).

No problem ;-)

> If this is OK, please feel free to add the image to tests/ts/blkid/images-fs/.

Done, thanks for the image!
https://github.com/karelzak/util-linux/commit/ea4dcdc788f2736c0f36cc59e79fb421e5bef915

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com




[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux