Re: [PATCH v2] libuuid: improve uuid_unparse() performance

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 26, 2020 at 03:38:27PM +0100, Aurelien LAJOIE wrote:
> +#ifdef UUID_UNPARSE_DEFAULT_UPPER
>  void uuid_unparse(const uuid_t uu, char *out)
> -{
> -	uuid_unparse_x(uu, out, FMT_DEFAULT);
> -}
> +	__attribute__((alias("uuid_unparse_upper")));
> +#else
> +void uuid_unparse(const uuid_t uu, char *out)
> +	__attribute__((alias("uuid_unparse_lower")));
> +#endif

The alias attribute is not portable to clang on Darwin.

 https://travis-ci.org/github/karelzak/util-linux/jobs/669244356?utm_medium=notification&utm_source=email

I have replaced the aliases with function calls.

 https://github.com/karelzak/util-linux/commit/bee464006776203a8cb545a35c86234181c7a55a

 Karel


-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com




[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux