On 2020/03/23 19:33, Karel Zak wrote:
> On Fri, Mar 20, 2020 at 01:55:43PM +0900, Damien Le Moal wrote:
>> libblkid/src/Makemodule.am | 1 +
>> libblkid/src/superblocks/superblocks.c | 3 +-
>> libblkid/src/superblocks/superblocks.h | 1 +
>> libblkid/src/superblocks/zonefs.c | 87 ++++++++++++++++++++++++++
>> 4 files changed, 91 insertions(+), 1 deletion(-)
>> create mode 100644 libblkid/src/superblocks/zonefs.c
>
> Applied (with a small change), thanks.
>
>> +struct zonefs_super {
>> +
>> + /* Magic number */
>> + __le32 s_magic;
>
> We use standard integer types rather than this kernel-ism ;-) Fixed.
>
> It would be nice to have a test image for zonefs, something small what
> we can add to tests/ts/blkid/images-fs/ ;-)
Overlooked that. With null-blk with zoned=1 option set, it is easy to create a
test device without any hardware. Because with an image file, we are not going
to get a zoned block device with loopback, which may cause some problems as that
would not be normal at all to see zonefs on a regular block device.
>
>
> Karel
>
--
Damien Le Moal
Western Digital Research
