Re: [PATCH] blkid: open device in nonblock mode.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 04, 2019 at 09:23:15PM +0100, Michal Suchanek wrote:
> When autoclose is set (kernel default but many distributions reverse the
> setting) opening a CD-rom device causes the tray to close.

I found unwanted side effect, open() with O_NONBLOCK also successes
when there is no medium. Unfortunately, we ignore I/O errors for
CDROMs to support some crazy hybrid media -- so overall result is many
I/O warnings in system logs.

I have added CDROM_DRIVE_STATUS to the logic to stop probing when
there is no medium. Let's hope it will be enough:

https://github.com/karelzak/util-linux/commit/dc30fd4383e57a0440cdb0e16ba5c4336a43b290


    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com




[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux