Re: [PATCH] blkid: open device in nonblock mode.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 06, 2019 at 09:02:56AM +0100, Michal Suchánek wrote:
> > If some random program using libblkid closes the tray I don't care that
> > much. However, many system scripts use blkid, probably to find a device

One of the random programs is udev:

   src/udev/udev-builtin-blkid.c:

       fd = open(devnode, O_RDONLY|O_CLOEXEC);
       if (fd < 0)
               return log_device_debug_errno(dev, errno, "Failed to open block device %s: %m", devnode);

       errno = 0;
       r = blkid_probe_set_device(pr, fd, offset, 0);

> > First off you need to explain it to all authors of all random scripts
> > out there.

That's what I'm doing for years :)

Anyway, I'm going to apply the patch, thanks for your investigation.

Let's hope it will not introduce any change on something else than
on cdroms and floppies.

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com





[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux