On Tue, Aug 27, 2019 at 02:26:08PM +0200, Patrick Steinhardt wrote:
> Triggered by commit f612c4c67 (tests: fix --unbuffered mode with
> ASAN, 2019-08-27), which says:
>
> Well, this patch sucks. It would be nice to have things in
> the way how it has been original expected by Patrick's patch,
> but ...
>
> So this commit here effectively reverts it and instead tries to
> improve the shortcomings of the original patch. First, it uses
> env(1) to set ASAN_OPTIONS instead of directly adding it to the
> args array to fix execution of "${args[@]}" "$@".
BTW, it's strange that ${args[@]} is interpreted in another way than
when we write "FOO=bar command" directly to the script. Sounds like
bash disadvantage.
> Second, it now supports both unbuffer(1) and stdbuf(1). The
> latter uses LD_PRELOAD tricks, which doesn't play nicely with
> ASAN, so it will not be used if ASAN has been requested. It's
> still valuable to have support for both, as many more systems
> will have stdbuf(1) from coreutils installed but not unbuffer(1)
> from expect.
>
> ---
>
> I wouldn't have minded, but as you state that your own patch
> sucks I thought my initial approach might be preferable and thus
> deemed it worthwhile to try and fix my original shortcomings.
OK, I'll try to play with it tomorrow :-) Thanks.
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
http://karelzak.blogspot.com
