On Mon, 15 Jul 2019 at 16:00, Karel Zak <kzak@xxxxxxxxxx> wrote:
>
> On Sat, Jul 13, 2019 at 01:30:27PM +0800, Yousong Zhou wrote:
> > On Thu, 27 Jun 2019 at 17:22, Yousong Zhou <yszhou4tech@xxxxxxxxx> wrote:
> > >
> > > The following commands manifests the problem. In old versions before
> > > commit 4762ae9d60 ("column: use libsmartcols for --table"), both of them
> > > should output with 2 "|"
> > >
> > > echo '||' | column -o '|' -s '|' -t
> > > echo '|| ' | column -o '|' -s '|' -t
> > >
> > > Fixes: 4762ae9d60 ("column: use libsmartcols for --table")
> > > Signed-off-by: Yousong Zhou <zhouyousong@xxxxxxxxxxxxx>
> > > ---
> >
> > Hi, do you think this is a real bug and the fix a proper one? should
> > I post a pull request through the github project page?
>
>
> Sorry for delay, I had vacation last weekend.
>
> I think your patch seems fine at first glance and send it to mailing
> list is good enough. You do not have to use github PR. Thanks.
>
> Karel
Does the patch still look good now ;)
yousong
>
> --
> Karel Zak <kzak@xxxxxxxxxx>
> http://karelzak.blogspot.com
