On Wed, 2019-02-27 at 23:22 +0100, Stanislav Brabec wrote:
> As login supports non-ASCII characters in the logname, agetty should be
> consistent.
>
> 8b58ffdd re-activated old and ASCII-only get_logname(), which restricted
A nit: please use this form to refer to other commits in commit
messages:
commit 8b58ffdd ('agetty: don't put the VC into canonical mode')
It improves readability.
> the input to ASCII only. As the code does not read whole characters,
> isascii(ascval) and isprint(ascval) returns nonsenses after entering a
> non-ASCII character.
>
> As keyboard maps don't contain unprintable non-control characters, it
> seems to be relatively safe to remove both checks.
>
> Signed-off-by: Stanislav Brabec <sbrabec@xxxxxxx>
> Cc: Lubomir Rintel <lkundrak@xxxxx>
> ---
> term-utils/agetty.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/term-utils/agetty.c b/term-utils/agetty.c
> index 1a3ebc308..0ef8ba36d 100644
> --- a/term-utils/agetty.c
> +++ b/term-utils/agetty.c
> @@ -2175,8 +2175,6 @@ static char *get_logname(struct issue *ie, struct options *op, struct termios *t
> case CTL('D'):
> exit(EXIT_SUCCESS);
> default:
> - if (!isascii(ascval) || !isprint(ascval))
> - break;
> if ((size_t)(bp - logname) >= sizeof(logname) - 1)
> log_err(_("%s: input overrun"), op->tty);
> if ((tp->c_lflag & ECHO) == 0)
> --
> 2.20.1
>
