Re: [PATCH] libuuid: Make the uuid_unparse functions inline

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jan 20, 2019 at 06:45:16PM -0800, Josh Triplett wrote:
> Various libraries, including libblkid, depend on libuuid solely to call
> uuid_unparse, which just prints a UUID.

It seems only libblkid requires solely uuid_unparse() :-) So, I guess
all we need is to use already implemented blkid_unparse_uuid() where
is the magic snprintf. I have applied this change:

 https://github.com/karelzak/util-linux/commit/c2435b946f574880201cb41d989d8d63d4bbf87d

The another stuff (e.g. mkswap, libfdisk, ...) depends on uuid_parse()
or/and uuid_generate(). So, libuuid is required there.

> Move the uuid_unparse functions to uuid.h and make them static
> inline, so that applications depending solely on the uuid_unparse
> functions don't need to pull in libuuid. Keep the out-of-line
> symbols for compatibility with existing applications.

It seems unnecessary.

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com



[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux