On Fri, Oct 19, 2018 at 10:08:17PM +0200, Stanislav Brabec wrote:
> This code implements both echo and Backspace processing!
:-) I guess it's the original serial line code...
> Note that the patch works even with less aggressive
> + tp->c_lflag &= ~(ICANON | ECHO | ECHOE | ECHOK | ECHOKE);
> I am not sure whether setting c_lflag to 0 is completely safe.
"It's aggressive" was my first feeling from the patch -- but it seems
there is nothing else in lflags relevant for Linux and agetty and for
serial line we do the same.
> Signed-off-by: Lubomir Rintel <lkundrak@xxxxx>
> Signed-off-by: Stanislav Brabec <sbrabec@xxxxxxx>
Thanks guys! I have applied the patch to master branch -- it's not
invasive patch ant it seems important enough for v2.33.
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
http://karelzak.blogspot.com
