Re: [PATCH 3/3] agetty: Reload only if it is really needed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 10, 2018 at 07:26:34PM +0200, Stanislav Brabec wrote:
> If netlink event arrives and related escapes are part of issue, agetty
> reloads and re-display the prompt. Reload is triggered not only by IP
> address change, but also by IPv6 RAs. In some environments it causes
> reload several times in a minute, and even complicates the login.
> 
> To prevent this, reload only if a real change appears.

Applied, thanks.

I have applied another changes too:

 - move all issue stuff to 'struct issue'
 - rename a few things
 - make code more robust

> This consists of:
> split print_issue_file() to several functions:
> 
> eval_issue_file() prints issue to memory. It does not affect terminal in
> any way.
> 
> print_issue_file() prints issue file from memory.
> 
> cmp_issue_file() compares the issue file and returns true, if reload is
> needed.

Let's hope people do not use \4 and \6 together with 't' because it
means time string in the output :-)

> Test suite:

Can you retest the current master branch with my changes? I do not
expect any issue, but for sure...

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com



[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux