Re: [PATCH] tests: don't lock fd 1 (stdout)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 07, 2018 at 12:38:07AM +0100, Ruediger Meier wrote:
> This is how this patch changes the test output:
> 
> --- /tmp/a      2018-03-06 22:31:15.000000000 +0000
> +++ /tmp/b      2018-03-06 22:30:34.000000000 +0000

git-am had really difficult time to accept to your patch with patch in the patch
comment :-)

> index d1c97e0b6..8cc148fb8 100644
> --- a/tests/functions.sh
> +++ b/tests/functions.sh
> @@ -226,6 +226,8 @@ function ts_init_env {
>  	local mydir=$(ts_abspath ${0%/*})
>  	local tmp
>  
> +	shopt -s nullglob
> +

1) It seems it breaks ts/ipcs/limits:ipcs_limits_check(), the sed
   arguments in the line

    "echo \$(cat /proc/sys/kernel/shmall) / 1024 \* $PAGE_SIZE | bc -l | sed 's/\..*//'"

are ignored, so with eval it calls

    eval echo '$(cat' '/proc/sys/kernel/shmall)' / 1024 '\*' 4096 '|' bc -l '|' sed

I have added

    shopt -u nullglob 

to the function to fix the problem. It seems it works.


2) I see

            mount: btrfs (fstab)                  ...
                : btrfs                       ... OK
                : auto                        ... SKIPPED (failed to lock fstab)


 and with ./run.sh --parallel I see another "failed to lock" messages :-(


Maybe we can use --nolocks for debian-kfreebsd (TS_NOLOCKS in
tests/functions.sh).

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux