On Thu, Feb 01, 2018 at 05:01:19PM +0100, Ruediger Meier wrote:
> On Thursday 01 February 2018, Karel Zak wrote:
> > Now we use on many places where commands executing another command:
> >
> > execvp(argv[optind], argv + optind);
> > err(EXIT_FAILURE, _("failed to execute %s"), argv[optind]);
> >
> > the problem is that EXIT_FAILURE is too generic and it does not
> > provide any way how to detect failed exec()s.
>
> I think you did a bit too much. I assume that these exec codes are only
> useful for the programs which get a "command" from the user's command
> line. So that the user can expect the original exit code of his
> wanted "command" if and only if it's not 126 or 127.
>
> So for taskset(1) these exit codes are good but maybe not needed for
> swapon(1) or eject(1).
I know, but it seems no problem and it's good way to consolidate the
error message and use the came code pattern.
> > I have added a new macro errexec() to replace err(EXIT_FAILURE, ...).
> >
> > The new macro is compatible with coreutils way:
> >
> > #define EX_EXEC_FAILED 126 /* Program located, but
> > not usable. */ #define EX_EXEC_ENOENT 127 /* Could not
> > find program to exec. */
>
>
> coreutils has even 2 more in "src/system.h" and each of these kind of
> exec programs are *only* using these ones.
I have copied from this file ;-)
>
> /* Exit statuses for programs like 'env' that exec other programs. */
> enum
> {
> EXIT_TIMEDOUT = 124, /* Time expired before child completed. */
> EXIT_CANCELED = 125, /* Internal error prior to exec attempt. */
> EXIT_CANNOT_INVOKE = 126, /* Program located, but not usable. */
> EXIT_ENOENT = 127 /* Could not find program to exec. */
> };
>
> like
> $ chroot --helpdassdf; echo $?
> chroot: unrecognized option '--helpdassdf'
> Try 'chroot --help' for more information.
> 125
>
> Other projects like bash only support 126 and 127, like we do now
yes, I guess it's good enough.
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
