On Wed, Jan 24, 2018 at 09:07:30PM +0000, Sami Kerola wrote:
> These warnings look like this:
> lib/exec_shell.c:33:6: error: symbol 'exec_shell' redeclared with different
> type (originally declared at ./include/exec_shell.h:1) - different modifiers
>
> In same go move attributes in front of these functions, this is how they
> should be.
[citation needed]
We have only "noreturn" in front of declarations, everything else is
behind. For header files it would be probably better to use all
attributes behind. I don't see reason for a change.
I'll cleanup exec_shell.h.
> Related smatch message is: error: attributes should be specified
> before the declarator in a function definition.
Fix smatch.
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
