On Sun, Dec 17, 2017 at 07:47:49PM -0500, J William Piggott wrote:
>
> So, there are some issues with commit 3c49b23
>
> * it contains multi-byte characters (which is what drew me to reading it).
Ah, it was copy & past from some white papers. Sorry.
> * it truncates one very important piece of the formula: ". . . (mod 7)."
> * it explains the values for 'e', but there is no 'e' in the code.
> * it doesn't include a row resolving 'e' in the table, so it is not
> obvious what it relates to in the code.
> * without citing it as an external reference, the comment language is confusing.
>
> Anyway, I took a shot at trying to write a comment:
Thanks!
>
> /*
> * The magic constants in the reform[] array are, in a simplified
> * sense, the remaining days after slicing into one week periods the total
> * days from the beginning of the year to the target month. That is,
> * weeks + reform[] days gets us to the target month. The exception is,
> * that for the months past February 'DOY - 1' must be used.
> *
> * DoY (Day of Year): total days to the target month
> *
> * Month 1 2 3 4 5 6 7 8 9 10 11 12
> * DoY 0 31 59 90 120 151 181 212 243 273 304 334
> * DoY % 7 0 3
> * DoY - 1 % 7 - -- 2 5 0 3 5 1 4 6 2 4
> * reform[] = { 0, 3, 2, 5, 0, 3, 5, 1, 4, 6, 2, 4 };
> *
> * Note: these calculations are for non leap years.
> */
>
> I cannot send this as a patch, because my system mangles the multi-byte
> characters so it won't apply cleanly.
>
> On a somewhat related note, multi-byte characters are also making it
> into the commit log; it's not a big deal I suppose, but it sure makes a
> mess for systems that don't support them.
Well, it's too late, and I think commit messages is not so big issue :-)
Applied, thanks!
Karel
>
>
>
>
--
Karel Zak <kzak@xxxxxxxxxx>
http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
