On Wed, Nov 15, 2017 at 11:01:37PM -0600, jgroves@xxxxxxxxxx wrote:
> From: John Groves <jgroves@xxxxxxxxxx>
>
> This patch adds libblkid recognition of Micron mpool formatted devices.
> It also adds a very simple crc32c() function, for use by probe_mpool().
>
> If there are objections to adding crc32c, I can re-submit without it, or
> make it static for probe_mpool(). I would prefer not to go without crc32c
> validation, because the only remaining check would be the magic number.
>
> Review comments and/or questions still welcome.
>
> Chages since v2:
>
> * Remove unused char * (yes,no) constants (overlooked in v2)
>
> Changes since v1:
>
> * probe_mpool() no longer calls blkid_probe_set_value to set
> VALID="yes"|"no". This was debug code that I had failed to excise
> previously.
>
> Thanks,
>
> John Groves (2):
> Add simple crc32c() function
> Add support for Micron mpool formatted drives
Applied, thanks!
John, it would be nice to have a regression test for mpool. It's
enough to send me gziped begin of the mpool device where is a valid
superblock (dd(1), 1000 bytes or so...).
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
