On 09/18/2017 11:07 AM, Karel Zak wrote:
On Sun, Sep 17, 2017 at 07:49:01PM +0100, Sami Kerola wrote:
from-gnulib-commit: e277cd7c6cf6435d9d4d380fd6cef0510e3f5afe
Signed-off-by: Sami Kerola <kerolasa@xxxxxx>
---
tools/git-version-gen | 137 +++++++++++++++++++++++++++++++++++++-------------
1 file changed, 102 insertions(+), 35 deletions(-)
I'm not sure about this. Did you check all the changes?
We have some local changes to the file, see
git whatchanged tools/git-version-gen
It would be nice to be sure that all works as expected.
I wouldn't touch this neither. Last year I've reviewed that really carefully
while fixing some issues with broken version numbers, see 85004b14 and also
the other ones from the same patch-set. Seems that Sami's patch would revert
some of these changes.
At that time there was also the question why not following gnulib and I tried to
justify this like this:
https://www.spinics.net/lists/util-linux-ng/msg13374.html
cu,
Rudi
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
