Re: rfkill(8) move and improvements

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 30, 2017 at 08:40:01PM +0100, Sami Kerola wrote:
> On 1 July 2017 at 10:06, Sami Kerola <kerolasa@xxxxxx> wrote:
> > I did couple last minute changes to my remote branch, that should now be
> > ready for final review.
> >
> > git://github.com/kerolasa/lelux-utiliteetit.git rfkill
> 
> Hello,
> 
> It's been a while. I did not get any review feedback, so I assume changes
> were ok. Would it be possible to move forward with the merge to
> util-linux upstream?

Merged. Changes:

* removed sys-utils/rfkill.py (nowhere used by build-system, also
  missing in Fedora package)

* added --disable-rfkill to make it possible to resolve conflicts with
  the original version

* usage() cleanup (USAGE_COMMANDS,  USAGE_COLUMNS, etc..)

* cleanup returns; it's always better to return 0,1,<0 in functions
  and use EXIT_* in the main() only (well, except err())

Please, tests it (now I'm on workstation without any relevant HW).

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux