Re: [PATCH] chsh: remove local /etc/shells parsing in favour of getusershell(3)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 30, 2017 at 10:09:41AM +0100, Sami Kerola wrote:
> On 30 August 2017 at 08:32, Karel Zak <kzak@xxxxxxxxxx> wrote:
> > On Mon, Aug 28, 2017 at 09:38:13PM +0100, Sami Kerola wrote:
> >> Less code, less bugs.  And if there are bugs at least share them with all
> >> other programs that use getusershell(3) from libc.
> >
> > Is it portable? ulibC etc.. ?
> 
> It is available in uClib
> https://git.uclibc.org/uClibc/tree/libc/unistd/usershell.c
> 
> Also in musl, but strangely in legacy directory
> https://git.musl-libc.org/cgit/musl/tree/src/legacy/getusershell.c

OK.

> But I guess the best option is to add check to configure.ac and write

I have add getusershell to configure to disable build on system where
the function is missing.

> util-linux getusershell() fallback when it is not available. I'll do that
> sometime soonish, about before end of the week.

I think we can be a little bit passive :-) (wait for any feedback before we 
add fallback code).

    Karel


-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux