On Tue, Aug 29, 2017 at 12:34:07PM -0400, J William Piggott wrote: > > hwaudit_on is only used in main() and hwclock_exit() and > that is unlikely to ever change. Hmm... the goal is minimize global variables to keep code readable. It's strange to have a control struct and use global variable in the same time. > Remove it from the control struct because it: > * cleans up an ugly directive in hwclock_exit > * removes an argument from usage() and hwclock_exit() > * makes usage() comply with util-linux standards I think usage() can call exit(EXIT_SUCCESS) and do not need play any games with audit at all. On another places we have "ctl" so it's fine fine to keep hwaudit_on within the control struct. Karel -- Karel Zak <kzak@xxxxxxxxxx> http://karelzak.blogspot.com -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html