Re: [PATCH] build: use --runstatedir instead of --localstatedir

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 27, 2017 at 04:00:42PM +0200, Andreas Henriksson wrote:
> Current GNU Coding Standards introduced the @runstatedir@ variable
> for this purpose. Lets use that instead.
> 
> The GNU default for @runstatedir@ is ${localstatedir}/run so util-linux
> still override the default to be /run to preserve the status quo from
> before. The only difference is that you'll now pass --runstatedir to
> override the location on the command line instead of --localstatedir.

Applied.

...

> -AS_CASE([$prefix:$localstatedir],
> -  [NONE:'${prefix}/var' | /usr:'${prefix}/var'],
> -    [localstatedir=/run
> -     AC_MSG_NOTICE([  --localstatedir defaults to /run])
> -    ]
> +AS_CASE([$prefix:$runstatedir],
> +    [NONE:'${localstatedir}/run' | /usr:'${localstatedir}/run'],
> +      [runstatedir=/run
> +       AC_MSG_NOTICE([  --runstatedir defaults to /run])
> +      ]
>  )
> -AC_SUBST([localstatedir])
> +AC_SUBST([runstatedir])

It seems we need somehow to support autoconf < 2.70 where is no
$runstatedir. So, I have modified the code to use fallback

    runstatedir='${localstatedir}/run'

It also seems we need to check for unmodified $localstatedir rather
than care about $prefix. So, I have improved the AS_CASE().

Please, git-pull from master branch and retest it with new autoconf
and your environment. Thanks.

    Karel


-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux