On 07/04/2017 03:58 AM, Karel Zak wrote: > On Mon, Jul 03, 2017 at 11:35:01AM -0400, J William Piggott wrote: >>>> To unsubscribe from this list: send the line "unsubscribe util-linux" in >>>> the body of a message to majordomo@xxxxxxxxxxxxxxx >>>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>>> >>>> >>> >>> What about the mentioned whitespaces for puts() to get printf >>> on one line? >>> >>> puts( _(" --update-drift update the RTC drift factor")); >>> printf(_(" --noadjfile do not use %1$s\n"), _PATH_ADJTIME); >>> printf(_(" --adjfile <file> use an alternate file to %1$s\n"), _PATH_ADJTIME); >>> puts( _(" --test dry run; use -D to view what would have happened")); >>> puts( _(" -D, --debug use debug mode")); >> >> Sure, if that is what Karel wants (it can be a separate patch). >> >> The only thing that I don't like about that choice is that it can cause >> puts() lines to wrap that otherwise would not. Since puts() is a lot >> more common than printf(), it seems like putting the alignment burden on >> printf() makes more sense. > > I think the idea is to use the extra space only if you mix printf and > puts in the same code block. We have on many place only puts (or > fputs) -- in this case the extra space is unnecessary. True. I meant that in mixed conditions *puts() seems more common. So if you have a full column of *puts() and one *printf(), forcing the puts lines to add whitespace could make many of them wrap, thus adding more ugliness to the source than if the alignment burden is on *printf(). Again, this is an anecdotal comment only, I don't have a strong opinion about it. For messy usage() blocks I typically toggle nowrap in my editor; so the alignment choice is not a big deal for me. If there aren't any other objections you could commit this set; the alignment change qualifies for a separate commit, I think. > > Karel > -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
