On 07/01/2017 07:51 PM, Karel Zak wrote: > On Sat, Jul 01, 2017 at 12:07:24PM -0400, J William Piggott wrote: >> >> On 06/30/2017 04:41 PM, J William Piggott wrote: >>> >>> Does anyone know why this small change added 43K (+23%) to the binary? >> >> I'm no compiler guru, but it appears to me that gcc is smart enough to >> exclude the unused strutils.h file without using '#if defined', and this >> new code pulls it in. >> >> So as I said when reviewing the commit, the new code needs to be in: >> #if defined(__linux__) && defined(__alpha__) >> https://marc.info/?l=util-linux-ng&m=149830453215524&w=2 >> >> After doing so the unused fat is no longer in the binary. I'm a bit >> surprised that strutils adds 43K though. >> >> Then adding '#if defined' to the header include actually made the binary >> 32 bytes larger. The striped binary was unchanged. >> >> I'm going to submit a patch to remove strutils from hwclock, but this >> information might apply to other commands that were changed? > > It would be better to compare striped versions. Percentage wise it's close to the same 19% (+10K). Seems unexpectedly large for just adding: + strutils_set_exitcode(EX_USAGE); + > > Karel > -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
