On Mon, Jun 26, 2017 at 10:27:44AM +0200, Karel Zak wrote:
> On Sun, Jun 25, 2017 at 05:45:56PM -0400, J William Piggott wrote:
> >
> > * Rudi didn't like cluttering boilerplate.c with seldom used USAGE_*
> > constants and I don't disagree with that point. I do think they should
> > be in the file for new contributor discovery purposes. As a compromise
> > I added the missing ones as a comment.
> >
> > * the newly added USAGE_COLUMNS could be used in disk-utils/fdisk-list.c:432
> > if Karel wants to drop the ' (for -o)'. I did not change it.
>
> I think USAGE_COLUMNS should be good enough everywhere and the
> additional notes (like ' (for -o)') are unnecessary.
>
> Maybe we can change the text to "Available output columns:" to make it
> more specific for readers.
Implemented & pull request merged. Thanks.
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
