Re: [PATCH 3/5] misc: fix more strutils related exit codes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 06/22/2017 04:43 PM, Ruediger Meier wrote:
> From: Ruediger Meier <ruediger.meier@xxxxxxxxxxx>
> 
> Found by grep:
> 
> grep -l "\bEXIT_\|exit *( *[0-9][0-9] *)\|strutils\.h" $(grep -L \
>     strutils_set_exitcode  $(git grep -l "_EX_\|FINDFS_\|BLKID_EXIT\|EX_USAGE" -- "*.c"))
> 
> The Command shows also some false positives (fstrim.c,
> context_mount.c, ...)
> 
> Signed-off-by: Ruediger Meier <ruediger.meier@xxxxxxxxxxx>
> ---
>  disk-utils/fsck.cramfs.c | 2 ++
>  disk-utils/fsck.minix.c  | 2 ++
>  disk-utils/mkfs.cramfs.c | 2 ++
>  disk-utils/mkfs.minix.c  | 2 ++
>  sys-utils/flock.c        | 2 ++
>  sys-utils/hwclock.c      | 2 ++
>  sys-utils/mount.c        | 2 ++
>  7 files changed, 14 insertions(+)
>

 --- >8

>  
> diff --git a/sys-utils/hwclock.c b/sys-utils/hwclock.c
> index 5433cd0..325106a 100644
> --- a/sys-utils/hwclock.c
> +++ b/sys-utils/hwclock.c
> @@ -1326,6 +1326,8 @@ int main(int argc, char **argv)
>  	};
>  	int excl_st[ARRAY_SIZE(excl)] = UL_EXCL_STATUS_INIT;
>  
> +	strutils_set_exitcode(EX_USAGE);
> +
>  	/* Remember what time we were invoked */
>  	gettimeofday(&startup_time, NULL);
>

If we keep this it needs to be: #if defined(__linux__) && defined(__alpha__)

I think the default EXIT_FAILURE is fine for this case.

--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux