Re: [PATCH] uuidparse: add new command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 19, 2017 at 11:22:48AM +0200, Ruediger Meier wrote:
> > +static void __attribute__((__noreturn__)) usage(FILE *out)
> 
> Do we really need this FILE argument? You are using only stdout in 
> uuidparse and that's good and should never change ;) I can't imagine 
> any good reason why usage should ever go to stderr and exit(1).
> 
> BTW currently I'm going through the whole project to correct all 
> commands where we spam the whole usage in case of errors.

That's legacy from time we used usage(stderr) for command line parsing
errors. Now we use errtryhelp().

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux