On Tue, Jun 13, 2017 at 10:11:29PM +0200, Rüdiger Meier wrote: > On 06/13/2017 10:00 PM, Karel Zak wrote: > > On Tue, Jun 13, 2017 at 04:52:20PM +0200, Rüdiger Meier wrote: > > > > sounds all we need is to add -Wimplicit-fallthrough=3 to ./configur > > > No, -Wimplicit-fallthrough=3 is what we have already now by default. > > > Just tested. Without doing anything "/* fallthrough */" disables the > > > warning. But Sami fixed also other comments and places without comments. > > > > > > So we could simply use "/* fallthrough */" everythere. > > > > Yes, that's what I mean (don't use the macro at all). > > > > Sami, can you update the patch and replace __ul_fallthrough with > > /* fallthrough */ ? > > > > Karel > > > > I've used one sed command on Sami's patch and submitted via github > https://github.com/karelzak/util-linux/pull/456 Applied, thanks! Karel -- Karel Zak <kzak@xxxxxxxxxx> http://karelzak.blogspot.com -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html