Re: [util-linux PATCH] umount: never 'stat' the path when "-c" is given.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 05, 2017 at 12:32:58PM +1000, NeilBrown wrote:
> diff --git a/libmount/src/context_umount.c b/libmount/src/context_umount.c
> index e663a703cca0..693891def0e1 100644
> --- a/libmount/src/context_umount.c
> +++ b/libmount/src/context_umount.c
> @@ -77,6 +77,7 @@ int mnt_context_find_umount_fs(struct libmnt_context *cxt,
>  	 * it's usable only for canonicalized stuff (e.g. kernel mountinfo).
>  	 */
>  	if (!mnt_context_mtab_writable(cxt) && *tgt == '/' &&
> +	    !mnt_context_is_nocanonicalize(cxt) &&
>  	    !mnt_context_is_force(cxt) && !mnt_context_is_lazy(cxt))
>  		rc = mnt_context_get_mtab_for_target(cxt, &mtab, tgt);

I've changed the code to be the mount table filter also usable for
--no-canonicalize. It seems better to avoid mnt_resolve_path() than
avoid all the filter.

It seems we can do more optimizations for huge mount tables (=autofs
issues) and canonicalizations (=NFS issues). I'll try to do it for
v2.30.1.

    Karel


-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux