Re: [PATCH 6/6] misc: fix some warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thursday 01 June 2017, J William Piggott wrote:
> On 05/31/2017 09:08 PM, Ruediger Meier wrote:
> > From: Ruediger Meier <ruediger.meier@xxxxxxxxxxx>
>
>  8< ---
>
> > diff --git a/lib/plymouth-ctrl.c b/lib/plymouth-ctrl.c
> > index 75d8b93..0e60341 100644
> > --- a/lib/plymouth-ctrl.c
> > +++ b/lib/plymouth-ctrl.c
> > @@ -85,7 +85,8 @@ static int open_un_socket_and_connect(void)
> >  	 * Please note that the PLYMOUTH_SOCKET_PATH has a
> >  	 * leading NULL byte to mark it as an abstract socket
> >  	 */
> > -	ret = connect(fd, &su, offsetof(struct sockaddr_un, sun_path) + 1
> > + strlen(su.sun_path+1)); +	ret = connect(fd, (const struct
> > sockaddr *) &su,
> > +	              offsetof(struct sockaddr_un, sun_path) + 1 +
> > strlen(su.sun_path+1));
>
>         ^^^^^^^^^^^^^^ whitespace
>
>  8< ---

What would be the right whitespace style? I've made one indentation 
(tab) and some spaces to align the broken line regarding  "connect(".

I'm using tab only for indentation but not for alignment, to let it look 
nice independently of editors tab witdth. Is that wrong?

cu,
Rudi


--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux