On 24 April 2017 at 11:42, Karel Zak <kzak@xxxxxxxxxx> wrote: > On Sun, Apr 23, 2017 at 09:58:11PM +0100, Sami Kerola wrote: >> The chfn and chsh is about usability provided by readline(). I did not add >> #ifdev HAVE_LIBREADLINE and make none libreadline compilation to work >> because it looks like sfdisk is doing the same. Let me know if fallback >> should be made to work. > > Are you sure? > > $ grep HAVE_LIBREADLINE disk-utils/sfdisk.c > #ifdef HAVE_LIBREADLINE > #ifdef HAVE_LIBREADLINE > #ifdef HAVE_LIBREADLINE > #ifdef HAVE_LIBREADLINE > #ifndef HAVE_LIBREADLINE > > ... we want to be independent on libreadline of course and it's also > important to keep the utils usable when stdin is not terminal. Let me look again, 8-/ Oh yes, I should go to specssavers. Corrected version below. https://github.com/kerolasa/lelux-utiliteetit/commit/9d647e4e3010b9214338f2a1d9e78e19a5358981 -- Sami Kerola http://www.iki.fi/kerolasa/ -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
